New architecture #33
Merged
New architecture #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to match android package name
mkopcins
reviewed
Nov 22, 2024
src/RnExecutorch.ts
Outdated
Comment on lines
6
to
7
| DEFAULT_SYSTEM_PROMPT, | ||
| DEFAULT_CONTEXT_WINDOW_LENGTH, |
There was a problem hiding this comment.
picky, I know, but better keep it in alphabetical order (revert this line swap)
mkopcins
reviewed
Nov 22, 2024
| EOT_TOKEN, | ||
| } from './constants'; | ||
| import { ResourceSource, Model } from './types'; | ||
| } from './constants/constants'; |
There was a problem hiding this comment.
also, maybe not for now, but the naming looks off (constants file inside constants dir) just a thought tho
mkopcins
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrated react native executorch library to new architecture, implemented new version of event emitters offered by new architecture, adjusted native code to implement codegen generated classes also updated react native version to 0.76 and changed folder structures so it's more self explanatory.
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes